[NFC][lldb][lldb-dap][test] show the expected value in the error message. #142030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show the expected value in the error message so we can see the expected value without searching through the log messages.
|
@llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) ChangesShow the expected value in the error message so we can see the expected value without searching through the log messages. Related #141689 Full diff: https://github.com/llvm/llvm-project/pull/142030.diff 1 Files Affected:
diff --git a/lldb/test/API/tools/lldb-dap/optimized/TestDAP_optimized.py b/lldb/test/API/tools/lldb-dap/optimized/TestDAP_optimized.py
index ae144ebdca46b..ba6da9469c204 100644
--- a/lldb/test/API/tools/lldb-dap/optimized/TestDAP_optimized.py
+++ b/lldb/test/API/tools/lldb-dap/optimized/TestDAP_optimized.py
@@ -45,9 +45,14 @@ def test_optimized_variable(self):
self.continue_to_breakpoints(breakpoint_ids)
optimized_variable = self.dap_server.get_local_variable("argc")
- self.assertTrue(optimized_variable["value"].startswith("<error:"))
+ expected_value: str = optimized_variable["value"]
+ self.assertTrue(
+ expected_value.startswith("<error:"),
+ f"expect error for value: '{expected_value}'",
+ )
error_msg = optimized_variable["$__lldb_extensions"]["error"]
self.assertTrue(
("could not evaluate DW_OP_entry_value: no parent function" in error_msg)
or ("variable not available" in error_msg)
)
+ self.continue_to_exit()
|
da-viper
changed the title
|
will wait for the PR build bot in case it catches it before pushing to main. |
Co-authored-by: Jonas Devlieghere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the expected value in the error message so we can see the expected value without searching through the log messages.
Related #141689